Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23394 )
Change subject: IMPALA-14013: DROP INCREMENTAL STATS throws NullPointerException for Iceberg tables ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@114 PS2, Line 114: if (partitionSet_ != null) { What about merging the two ifs from L113 and L119 (OR) and print a more general error message? Like: ("DROP INCREMENTAL STATS... PARTITION not supported for table " + tableName_); or: ("DROP INCREMENTAL STATS... PARTITION is only supported for Hive tables"); http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@115 PS2, Line 115: DROP INCREMENTAL ... DROP INCREMENTAL STATS ... http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@116 PS2, Line 116: non-HDFS Should be "non-filesystem-based" FeFsTable is the common interface for all tables that are filesystem-based, like legacy Hive table format, Hive ACID and Iceberg. HDFS is one of these filesystems, but these table formats can be on Ozone or object storage (S3) as well, so referring to these tables as 'HDFS' or 'non-HDFS' tables is a bit misleading. http://gerrit.cloudera.org:8080/#/c/23394/2/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@121 PS2, Line 121: DROP INCREMENTAL ... DROP INCREMENTAL STATS ... http://gerrit.cloudera.org:8080/#/c/23394/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/23394/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@391 PS2, Line 391: ---- QUERY : DROP INCREMENTAL STATS ice_alltypes_part PARTITION (i=1); : ---- CATCH : DROP INCREMENTAL ... PARTITION not supported for Iceberg table Could be an Analyzer test in AnalyzeDDLTest. -- To view, visit http://gerrit.cloudera.org:8080/23394 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3d9ef45a9c9ddce9a5e43c5058ae84f919e0283 Gerrit-Change-Number: 23394 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Mon, 15 Sep 2025 12:29:31 +0000 Gerrit-HasComments: Yes
