Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23159 )
Change subject: IMPALA-14082: Support batch processing of RELOAD events on same table ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/23159/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23159/6/tests/custom_cluster/test_events_custom_configs.py@578 PS6, Line 578: > This config is introduced to address the test failure associated with this Thanks for the explanation! Could you please add a comment to summarize these? E.g. BatchPartitionEvent#isOlderEvent() requires enable_skipping_older_events=true to skip older events. http://gerrit.cloudera.org:8080/#/c/23159/7/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23159/7/tests/custom_cluster/test_events_custom_configs.py@631 PS7, Line 631: # Test to verify if older events from hive are being skipped in event processor. > This variable name is deceptive (https://github.com/apache/impala/commit/32 It's not just about naming. We set this to true in test_refresh_invalidate_events_enable_sync_to_latest_events where we have --enable_sync_to_latest_event_on_ddls=true. And use it as false in test_refresh_invalidate_events where the enable_sync_to_latest_event_on_ddls flag is also false. I'm confused why we can't set it to true when the flag enable_sync_to_latest_event_on_ddls is false. Will the test fail somewhere? http://gerrit.cloudera.org:8080/#/c/23159/10/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23159/10/tests/custom_cluster/test_events_custom_configs.py@652 PS10, Line 652: self.client.execute("refresh {}.{} partition(year=2022)" What if the 10 RELOAD events arrive and be processed before this REFRESH statement? Will the test fail? http://gerrit.cloudera.org:8080/#/c/23159/10/tests/custom_cluster/test_events_custom_configs.py@846 PS10, Line 846: "select * from {}".format(tbl)) add "order by i" to make the results determined. -- To view, visit http://gerrit.cloudera.org:8080/23159 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3e9a99b666a1c928ac2a136bded1e5420f77dab Gerrit-Change-Number: 23159 Gerrit-PatchSet: 10 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 15 Sep 2025 14:06:32 +0000 Gerrit-HasComments: Yes
