Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23434 )
Change subject: IMPALA-14450: Simplify Java version selection ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23434/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23434/4//COMMIT_MSG@23 PS4, Line 23: system Java, unset JAVA_HOME after e.g. update-java-alternatives. I think avoiding this was the main benefit of IMPALA_JAVA_HOME_OVERRIDE. It doesn't seem like a strong argument for the added indirection. -- To view, visit http://gerrit.cloudera.org:8080/23434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68435ca69522f8310221a0f3050f13d86568b9da Gerrit-Change-Number: 23434 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 17 Sep 2025 22:15:15 +0000 Gerrit-HasComments: Yes
