Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23434 )
Change subject: IMPALA-14450: Simplify Java version selection ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/23434/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23434/4//COMMIT_MSG@11 PS4, Line 11: 1. If IMPALA_JDK_VERSION is set, use the OS JDK version from a known > Running https://jenkins.impala.io/job/ubuntu-22.04-from-scratch-java17/46/, Succeeded. http://gerrit.cloudera.org:8080/#/c/23434/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23434/5//COMMIT_MSG@31 PS5, Line 31: Stops printing from impala-config-java.sh. > The side effect is that bootstrap_system.sh will not print this information I think the version selection has become a bit simpler here, and you can still identify what version was chosen by the openjdk package it installs. http://gerrit.cloudera.org:8080/#/c/23434/5/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/23434/5/bin/run-all-tests.sh@36 PS5, Line 36: # Preserve build-time IMPALA_JAVA_TARGET to restore to its original value in > I need to retest this. An addendum to IMPALA-14187 mentioned it was a probl Ok, this was needed because calcite-planner is built after this, and we want to use the same target we used to build everything else. Restored the old code. http://gerrit.cloudera.org:8080/#/c/23434/5/bin/run-all-tests.sh@39 PS5, Line 39: if [ ! -z "${TEST_JAVA_HOME_OVERRIDE:-}" ]; then > Agree to drop TEST_JAVA_HOME_OVERRIDE. I'm going to leave this, it's not a burden to ignore it right now. -- To view, visit http://gerrit.cloudera.org:8080/23434 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68435ca69522f8310221a0f3050f13d86568b9da Gerrit-Change-Number: 23434 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 15:45:36 +0000 Gerrit-HasComments: Yes
