Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23438 )
Change subject: IMPALA-14451: Log if memory-based admission is skipped ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23438/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/23438/1/be/src/scheduling/admission-controller.cc@1059 PS1, Line 1059: Pool '$0' doesn't have memory resources configured, " : "skipping memory-based query admission. Please note that it can result in " : "query failures due to memory exhaustion. I think it will be better to call out the config name here. Is it impala.admission-control.max-query-mem-limit.<pool_name>? Also better to use stronger language to set it to concrete value instead of -1 (ignore). -- To view, visit http://gerrit.cloudera.org:8080/23438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib98482abc0fbcb53552adfd89cf6d157b17527fd Gerrit-Change-Number: 23438 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 18:50:42 +0000 Gerrit-HasComments: Yes
