Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23423 )
Change subject: IMPALA-14437: Fix regression in FileMetadataLoader.createFd() ...................................................................... Patch Set 2: (1 comment) Thanks for fixing it so quickly! http://gerrit.cloudera.org:8080/#/c/23423/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23423/2//COMMIT_MSG@17 PS2, Line 17: Some additional info that may be worth mentioning: Impala has its own set of filesystems that support storage ids (block locations). This set is maintained in FileSystemUtil.SCHEME_SUPPORT_STORAGE_IDS. Hadoop filesystems might still return LocatedFileStatus objects even if they are not included in Impala's FileSystemUtil.SCHEME_SUPPORT_STORAGE_IDS. E.g. S3AFileSystem is not included in this set, even though it returns S3ALocatedFileStatus objects that contain a dummy block location. Therefore it is not enough to check if we got an instance of LocatedFileStatus, we need to use Impala's set to decide if we should create an Impala FileDescriptor object with block locations or not. -- To view, visit http://gerrit.cloudera.org:8080/23423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie16c5d7b020a59b5937b52dfbf66175ac94f60cd Gerrit-Change-Number: 23423 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 15 Sep 2025 09:44:06 +0000 Gerrit-HasComments: Yes
