Michael Smith has uploaded this change for review. (
http://gerrit.cloudera.org:8080/23452
Change subject: IMPALA-14450: (Addendum) Fix other numeric comparison
......................................................................
IMPALA-14450: (Addendum) Fix other numeric comparison
Fixes
set-impala-java-tool-options.sh: line 25: ((: 1.8: syntax error:
invalid arithmetic operator (error token is ".8")
Double parentheses - ((...)) - only support integer arithmetic. I can't
find any standard way to do decimal comparison in shells, so switch to
extract Java major version as an integer and compare that.
OpenJDK 8 has always considered "-target 1.8" and "-target 8" equivalent
https://github.com/openjdk/jdk/blob/jdk8-b01/langtools/src/share/classes/com/sun/tools/javac/jvm/Target.java#L105
so maven target can be set to 8 when IMPALA_JAVA_TARGET is 8.
Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
---
M bin/impala-config.sh
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/23452/1
--
To view, visit http://gerrit.cloudera.org:8080/23452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15cdd1859be51d3708f1c348e898831df2a92b13
Gerrit-Change-Number: 23452
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com>
