Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10629 )
Change subject: IMPALA-7137. Support configuring Frontend to use LocalCatalog ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/10629/4/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/10629/4/be/src/runtime/exec-env.cc@85 PS4, Line 85: DEFINE_bool(use_local_catalog, false, suffixing this with "_hidden" will suppress this from help. useful while the new functionality rolls out. for example, the flag controlling krpc was in this state until it was made the default. http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/10629/2/fe/src/main/java/org/apache/impala/service/Frontend.java@197 PS2, Line 197: new AuthorizationPo > I agree this is a little goofy, though I was trying to maintain the exact o I see, you were trying to re-use L224. Pls add a comment: "initializes authzChecker" http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java@163 PS4, Line 163: //TODO: Make the reload interval configurable. nit: add a space. http://gerrit.cloudera.org:8080/#/c/10629/4/fe/src/main/java/org/apache/impala/service/Frontend.java@232 PS4, Line 232: public FeCatalog getCatalog() { nit: one line -- To view, visit http://gerrit.cloudera.org:8080/10629 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c9665bd031d23608740b23eef301970af9aa764 Gerrit-Change-Number: 10629 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Jun 2018 21:46:24 +0000 Gerrit-HasComments: Yes
