Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23204 )
Change subject: IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond cluster membership recovering ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/23204/7/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23204/7/tests/custom_cluster/test_admission_controller.py@2254 PS7, Line 2254: client1 = coord1.service.create_hs2_client() I suggest to use with-as statement so you can skip closing clients manually at L2311-L2312 below. with coord1.service.create_hs2_client() as client1, \ coord2.service.create_hs2_client() as client2: http://gerrit.cloudera.org:8080/#/c/23204/7/tests/custom_cluster/test_admission_controller.py@2259 PS7, Line 2259: client2 = coord2.service.create_hs2_client() : handle2 = client2.execute_async(short_query) : # Wait until the second query is confirmed to be queued. : self._wait_for_change_to_profile(handle2, "Admission result: Queued", client=client2) > Umm, I don't see any issue running the test locally or in the build with th Test works after I rebase. It took 120s to complete though. Is there any flags that can be set to speed up the test a bit? -- To view, visit http://gerrit.cloudera.org:8080/23204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e Gerrit-Change-Number: 23204 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Sun, 28 Sep 2025 03:06:54 +0000 Gerrit-HasComments: Yes
