Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23436 )
Change subject: IMPALA-14447: Parallelize table loading in getMissingTables() ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/23436/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/23436/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1572 PS6, Line 1572: LOG.trace("Candidate tables to lookup in catalog/cache for {} {}: {}", pathType, > Please add more context to this message. Done http://gerrit.cloudera.org:8080/#/c/23436/6/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/23436/6/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@323 PS6, Line 323: needsAnyTableMasksInQuery_); > Consider using @ThreadSafe annotations. Done. Unfortunately, @ThreadSafe annotations is not applicable to method. http://gerrit.cloudera.org:8080/#/c/23436/6/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@359 PS6, Line 359: if (tbls.isEmpty()) return missingTbls; > Should we add an option to control numbe of threads higher and lower than c Done -- To view, visit http://gerrit.cloudera.org:8080/23436 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97a5165844ae846b28338d62e93a20121488d79f Gerrit-Change-Number: 23436 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 29 Sep 2025 22:18:11 +0000 Gerrit-HasComments: Yes
