Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10060 )

Change subject: IMPALA-5216: Make admission control queuing async
......................................................................


Patch Set 19:

So it turns out the test was already broken - the query was rejected by 
admission control - but passing by coincidence because of a quirk of how 
exceptions were being wrapped and a bug in _check_exception(). 
https://github.com/apache/impala/blob/b56ac8f/tests/query_test/test_udfs.py#L50.
 Note the "'Cancelled' not in e.inner_exception.message" bit - the "not" 
shouldn't be there.

The fix is to manually set buffer_pool_limit so that the query makes it through 
admission control. I'll loop the test a bit to make sure it's not flaky.


--
To view, visit http://gerrit.cloudera.org:8080/10060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf
Gerrit-Change-Number: 10060
Gerrit-PatchSet: 19
Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 22:46:51 +0000
Gerrit-HasComments: No

Reply via email to