Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23535 )
Change subject: IMPALA-14494: Tag catalogd logs of GetPartialCatalogObject requests with correct query ids ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23535/2/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: http://gerrit.cloudera.org:8080/#/c/23535/2/be/src/catalog/catalog.cc@277 PS2, Line 277: req.header.query_id > Just to confirm, is this ok to access without checking req.header.__isset.q I think it's fine. 'query_id' in TCatalogServiceRequestHeader is initialized using the default constructor which sets its hi and lo numbers to 0. Here 'header' is a required field of TWaitForHmsEventRequest so we don't check it like other places. In other places, we need to check if 'header' is set and construct a local variable 'query_id' before that. Checking 'req.header.__isset.query_id' is to avoid redundant assignment. -- To view, visit http://gerrit.cloudera.org:8080/23535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie63363ac60e153e3a69f2a4cf6a0f4ce10701674 Gerrit-Change-Number: 23535 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 14 Oct 2025 04:44:27 +0000 Gerrit-HasComments: Yes
