Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23546 )
Change subject: IMPALA-10204: Make AdmitQuery params more efficient ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23546/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/23546/2/be/src/service/client-request-state.cc@671 PS2, Line 671: std::string().swap(req.query_plan); > I think it's mainly because these don't guarantee releasing underlying cont Ah, clear() wouldn't. And operator= seems like it should change capacity, but doesn't look like it's required to. A comment would be nice to make that clear. -- To view, visit http://gerrit.cloudera.org:8080/23546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ba5e8818336bd1fc3ad604a0acee5eb7a1116c4 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 18:35:07 +0000 Gerrit-HasComments: Yes
