Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23547 )

Change subject: IMPALA-14502: Not tracking metrics in IncompleteTable
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

> Patch Set 3: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12580/

The failure does not seem to relate with this patch.

http://gerrit.cloudera.org:8080/#/c/23547/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java
File fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java:

http://gerrit.cloudera.org:8080/#/c/23547/2/fe/src/main/java/org/apache/impala/catalog/IncompleteTable.java@221
PS2, Line 221:
             :   /**
             :    * Don't initialize any metrics to save memory space.
             :    */
             :   @Override
> This is a good point! Getting the metric will also add it if it doesn't exi
Done



--
To view, visit http://gerrit.cloudera.org:8080/23547
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0fcfeab99bbfbefe618d0abf7f2482a0cc5ef9f
Gerrit-Change-Number: 23547
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Fri, 17 Oct 2025 14:54:46 +0000
Gerrit-HasComments: Yes

Reply via email to