Mihaly Szjatinya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/23455 )
Change subject: IMPALA-14108: Add support for SHOW FILES IN table PARTITION for Iceberg tables ...................................................................... IMPALA-14108: Add support for SHOW FILES IN table PARTITION for Iceberg tables This patch implements partition filtering support for SHOW FILES statement on Iceberg tables, based on the functionality added in IMPALA-12243. Prior to this change the syntax resulted in impalad crash. Key changes: - Added ShowFilesStmt.analyzeIceberg() to validate and transform partition expressions using IcebergPartitionExpressionRewriter and IcebergPartitionPredicateConverter. After that it collects matching file paths using IcebergUtil.planFiles(). - Added FeIcebergTable.Utils.getIgetIcebergTableFilesFromPaths() to accept pre-filtered file lists from analysis phase. - Enhanced TShowFilesParams thrift struct with optional iceberg_files field to pass pre-filtered file paths from frontend to backend. Testing: - Analyzer tests for negative cases: non-existent partitions, invalid expressions, non-partition columns, unsupported transforms. - Analyzer tests for positive cases: all transform types, complex expressions. - E2E tests covering every partition transform type with various predicates. - Schema evolution and rollback scenarios. The implementation follows the AlterTableDropPartition's pattern where analysis phase performs validation / metadata retriaval and execution phase handles result formatting and display. Change-Id: Ibb9913e078e6842861bdbb004ed5d67286bd3152 --- M common/thrift/Frontend.thrift M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java M fe/src/main/java/org/apache/impala/analysis/ShowFilesStmt.java M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java M fe/src/main/java/org/apache/impala/service/Frontend.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java A testdata/workloads/functional-query/queries/QueryTest/iceberg-show-files-partition.test M tests/query_test/test_iceberg.py 9 files changed, 629 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/23455/2 -- To view, visit http://gerrit.cloudera.org:8080/23455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibb9913e078e6842861bdbb004ed5d67286bd3152 Gerrit-Change-Number: 23455 Gerrit-PatchSet: 2 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]>
