Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23530 )
Change subject: IMPALA-14092 Part1: Prohibit Unsupported Operation for paimon table ...................................................................... Patch Set 2: (2 comments) Looks OK to me, thank you for continuing this work. Just have nits. http://gerrit.cloudera.org:8080/#/c/23530/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23530/2//COMMIT_MSG@9 PS2, Line 9: This patch is to prohibit un-supported operation against : paimon table. All unsupported operations are added the : checked in the analyze stage in order to avoid : mis-operation. Please mention what is currently supported as a reminder. Is it only CREATE and DROP for now? http://gerrit.cloudera.org:8080/#/c/23530/2/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java File fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java: http://gerrit.cloudera.org:8080/#/c/23530/2/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java@64 PS2, Line 64: refractor to fix the : * incompatible conversion to hive timestampLocalTZTypeInfo, it : * is not supported by impala. Can you elaborate more on this comment? How is this different from the original org.apache.paimon.hive.HiveTypeUtils? Where is this incompatible conversion adjusted? -- To view, visit http://gerrit.cloudera.org:8080/23530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie39fa4836cb1be1b1a53aa62d5c02d7ec8fdc9d7 Gerrit-Change-Number: 23530 Gerrit-PatchSet: 2 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 16:19:13 +0000 Gerrit-HasComments: Yes
