Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23317 )
Change subject: IMPALA-14115: Calcite planner: Added top-n analytic PlanNode optimization. ...................................................................... Patch Set 16: Code-Review+2 (1 comment) A comment below which is unrelated to this patch. Rest LGTM. http://gerrit.cloudera.org:8080/#/c/23317/16/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test: http://gerrit.cloudera.org:8080/#/c/23317/16/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q08.test@909 PS16, Line 909: | 04:SCAN HDFS [tpcds_partitioned_parquet_snap.customer_address, RANDOM] Unrelated to this patch, the tpcds-q08 is missing the large IN predicate pushed down the customer_address table scan. This should be looked into separately. -- To view, visit http://gerrit.cloudera.org:8080/23317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6fa6781db56771b13b0cf49bd236f776016bf8d Gerrit-Change-Number: 23317 Gerrit-PatchSet: 16 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 10 Oct 2025 15:54:29 +0000 Gerrit-HasComments: Yes
