Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23264 )
Change subject: IMPALA-14271: Reapply the core piece of IMPALA-6984 ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23264/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/23264/3/be/src/runtime/coordinator-backend-state.cc@703 PS3, Line 703: cause > nit. causes Done http://gerrit.cloudera.org:8080/#/c/23264/3/be/src/runtime/coordinator-backend-state.cc@721 PS3, Line 721: > How about rechecking IsDoneLocked() immediately after reacquiring the lock Added that check here. I think you're right that there is a potential timing window here. I tried to produce an issue with this by adding sleeps here, but I couldn't get it to fail. -- To view, visit http://gerrit.cloudera.org:8080/23264 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia058b03c72cc4bb83b0bd0a19ff6c8c43a647974 Gerrit-Change-Number: 23264 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 22 Sep 2025 21:03:48 +0000 Gerrit-HasComments: Yes
