Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23469 )
Change subject: IMPALA-14092: Support querying of paimon data table via JNI ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23469/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23469/3//COMMIT_MSG@62 PS3, Line 62: - Create table tests in functional_schema_template.sql : - Add TestPaimonScannerWithLimit in test_scanners.py : - Add unit test for AnalyzeDDLTest.java. : - Add unit test for AnalyzerTest.java. This patch is quite large. Is it possible to split this patch into two parts? 1. DDL & Analyzer support and tests in FE side. 2. The querying of paimon data table via JNI. AFAIK, this is probably the 3rd Scanner implementation, aside of ExternalDataSourceExecutor and IcebergRowReader, where reading rows goes through JNI instead of impemented natively in C++ & DiskIoMgr (see be/src/exec/iceberg-metadata/ for Iceberg metadata reader through JNI). I'm not sure now the performance / memory management will be, since Paimon read might return much more rows than reading Iceberg metadata rows. Can you explain a little bit on that perf / memory aspect? It is ok if that is still unknown though. -- To view, visit http://gerrit.cloudera.org:8080/23469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ecab952622e99109927056461d3d5d12f4b295f Gerrit-Change-Number: 23469 Gerrit-PatchSet: 3 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 06 Oct 2025 19:41:03 +0000 Gerrit-HasComments: Yes
