ji chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/23530 )
Change subject: IMPALA-14092 Part1: Prohibit Unsupported Operation for paimon table ...................................................................... Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/23530/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23530/2//COMMIT_MSG@9 PS2, Line 9: This patch is to prohibit un-supported operation against : paimon table. All unsupported operations are added the : checked in the analyze stage in order to avoid : mis-operation. > Please mention what is currently supported as a reminder. Is it only CREATE Done http://gerrit.cloudera.org:8080/#/c/23530/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23530/3//COMMIT_MSG@12 PS3, Line 12: . > nit: missing space after dot. Done http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java: http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java@87 PS3, Line 87: E RENAM > typo: should be RENAME Done http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java: http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java@125 PS3, Line 125: PAIMON > nit: in AlterTableOrViewRenameStmt.java it was all capital, here it's all l Done http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@412 PS3, Line 412: PAIMON > nit: upper/lower case is inconsistent with other files. Done http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/analysis/DropStatsStmt.java@113 PS3, Line 113: PAIMON > nit: inconsistent lower/upper case with other files Done http://gerrit.cloudera.org:8080/#/c/23530/2/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java File fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java: http://gerrit.cloudera.org:8080/#/c/23530/2/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java@64 PS2, Line 64: refactor to fix the : * following incompatible conversion issue: : * paimon type LocalZonedTimes > Can you elaborate more on this comment? Done http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java File fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java: http://gerrit.cloudera.org:8080/#/c/23530/3/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonHiveTypeUtils.java@64 PS3, Line 64: refactor > nit: refactor Done http://gerrit.cloudera.org:8080/#/c/23530/3/tests/query_test/test_paimon.py File tests/query_test/test_paimon.py: http://gerrit.cloudera.org:8080/#/c/23530/3/tests/query_test/test_paimon.py@54 PS3, Line 54: ve > nit: indentation is off Done -- To view, visit http://gerrit.cloudera.org:8080/23530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie39fa4836cb1be1b1a53aa62d5c02d7ec8fdc9d7 Gerrit-Change-Number: 23530 Gerrit-PatchSet: 4 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Sun, 19 Oct 2025 12:30:30 +0000 Gerrit-HasComments: Yes
