Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/23154 )
Change subject: IMPALA-9846: Enable Aggregated Runtime Profile by Default ...................................................................... Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/23154/18/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/23154/18/be/src/util/runtime-profile.cc@2294 PS18, Line 2294: result.total = std::accumulate(vals.begin(), vals.end(), 0.0L); Total is not a good metric to present in many cases. We should insead print the number of values where applicable. The total can be derived from the average*nvalues if something need it. http://gerrit.cloudera.org:8080/#/c/23154/18/be/src/util/runtime-profile.cc@2320 PS18, Line 2320: (*s) << prefix << " - " << name << ": total=" << PrettyPrinter::Print(BitcastToInt64(stats.total), unit_, true); > line too long (116 > 90) Looking at the test changes, tHis makes the output confusing. Stats should be aggregated differently depending on the nature of the stat and what is important to convey, usually (min/max/avg). http://gerrit.cloudera.org:8080/#/c/23154/18/be/src/util/runtime-profile.cc@2397 PS18, Line 2397: counter_json.AddMember("total", stats.total, document.GetAllocator()); See above. http://gerrit.cloudera.org:8080/#/c/23154/18/be/src/util/runtime-profile.cc@3355 PS18, Line 3355: os << "UNAGGREGATED"; EXPANDED maybe better than UNAGGREGATED? -- To view, visit http://gerrit.cloudera.org:8080/23154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41d6322361fba82c946efd614cc7d28cb1c36e8 Gerrit-Change-Number: 23154 Gerrit-PatchSet: 18 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 14:27:08 +0000 Gerrit-HasComments: Yes
