Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23523 )
Change subject: IMPALA-14408: Use regular path for Calcite planner instead of CalciteJniFrontend ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/23523/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/UnsupportedChecker.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/UnsupportedChecker.java: http://gerrit.cloudera.org:8080/#/c/23523/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/UnsupportedChecker.java@34 PS1, Line 34: private static Pattern LEFT_SEMI = Pattern.compile(".*\\bleft\\ssemi\\b.*", : Pattern.CASE_INSENSITIVE); : : private static Pattern RIGHT_SEMI = Pattern.compile(".*\\bright\\ssemi\\b.*", : Pattern.CASE_INSENSITIVE); : : private static Pattern LEFT_ANTI = Pattern.compile(".*\\bleft\\santi\\b.*", : Pattern.CASE_INSENSITIVE); : : private static Pattern RIGHT_ANTI = Pattern.compile(".*\\bright\\santi\\b.*", : Pattern.CASE_INSENSITIVE); : : private static Pattern INPUT_FILE_NAME = Pattern.compile(".*\\binput__file__name\\b.*", : Pattern.CASE_INSENSITIVE); : : private static Pattern FILE_POSITION = Pattern.compile(".*\\bfile__position\\b.*", : Pattern.CASE_INSENSITIVE); : : private static Pattern TABLE_NOT_FOUND = : Pattern.compile(".*\\bTable '(.*)' not found\\b.*", Pattern.CASE_INSENSITIVE); : : private static Pattern COLUMN_NOT_FOUND = : Pattern.compile(".*\\bColumn '(.*)' not found\\b.*", Pattern.CASE_INSENSITIVE); > Any tests to validate this pattern matching? In an upcoming patch, the ParserTest will be completely tested on Calcite which includes tests for these. http://gerrit.cloudera.org:8080/#/c/23523/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/UnsupportedChecker.java@60 PS1, Line 60: ;; > nit: double semicolon. Done http://gerrit.cloudera.org:8080/#/c/23523/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/UnsupportedChecker.java@75 PS1, Line 75: ;; > nit: double semicolon. Done -- To view, visit http://gerrit.cloudera.org:8080/23523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732516ca8f7ea64f73484efd67071910c9b62c8f Gerrit-Change-Number: 23523 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 16:23:43 +0000 Gerrit-HasComments: Yes
