Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23468 )
Change subject: IMPALA-14501: Migrate most scripts from impala-python to impala-python3 ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23468/5/bin/check-rat-report.py File bin/check-rat-report.py: http://gerrit.cloudera.org:8080/#/c/23468/5/bin/check-rat-report.py@1 PS5, Line 1: #!/usr/bin/python3 nit: should we normalize using env? /usr/bin/env python3 http://gerrit.cloudera.org:8080/#/c/23468/5/tests/metadata/test_column_unicode.py File tests/metadata/test_column_unicode.py: http://gerrit.cloudera.org:8080/#/c/23468/5/tests/metadata/test_column_unicode.py@a2 PS5, Line 2: Why remove "coding: utf-8" here but not later files? -- To view, visit http://gerrit.cloudera.org:8080/23468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If209b761290bc7e7c716c312ea757da3e3bca6dc Gerrit-Change-Number: 23468 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 22:24:33 +0000 Gerrit-HasComments: Yes
