Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10709 )

Change subject: IMPALA-7111: avoid use of boost::split in CheckPluginEnabled
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10709/1/be/src/exec/hdfs-plugin-text-scanner.cc
File be/src/exec/hdfs-plugin-text-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/10709/1/be/src/exec/hdfs-plugin-text-scanner.cc@107
PS1, Line 107:   if 
(!CommaSeparatedContains(FLAGS_enabled_hdfs_text_scanner_plugins, plugin_name)) 
{
Up to you, but since this isn't performance sensitive, you could use split.h 
from gutil.

I think the following is similar.

vector<string> x = strings::Split(FLAGS_..., ",");
if (x.find(plugin_name) != ...::npos) { ...
}


http://gerrit.cloudera.org:8080/#/c/10709/1/be/src/util/string-util-test.cc
File be/src/util/string-util-test.cc:

http://gerrit.cloudera.org:8080/#/c/10709/1/be/src/util/string-util-test.cc@83
PS1, Line 83:   // Basic tests with string present.
Test explicitly that this doesn't whitespace-trim the entries. I don't remember 
if boost:split does or doesn't trim.



--
To view, visit http://gerrit.cloudera.org:8080/10709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I17b7f083731a33b832035f24900e351e2cb2feb8
Gerrit-Change-Number: 10709
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jun 2018 21:11:38 +0000
Gerrit-HasComments: Yes

Reply via email to