Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23524 )
Change subject: WIP: do not review, Calcite patch with most fixes for v1 ...................................................................... Patch Set 7: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java: http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java@40 PS7, Line 40: protected static final Logger LOG = LoggerFactory.getLogger(AnalyzedInPredicate.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java: http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java@46 PS7, Line 46: * Impala provides, not the default type. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@228 PS7, Line 228: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java: http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java@162 PS7, Line 162: RexNode expandedOperand = ImpalaRexUtil.expandSearch(visitor.getRexBuilder(), operand); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java: http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java@44 PS7, Line 44: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java: http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java@92 PS7, Line 92: return false; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@193 PS7, Line 193: RelOptCluster newCluster = RelOptCluster.create(planner_, rexBuilder); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java: http://gerrit.cloudera.org:8080/#/c/23524/7/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java@83 PS7, Line 83: protected static final Logger LOG = LoggerFactory.getLogger(TestReduceExprShuttle.class.getName()); line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc0d0101a8136d8ef7fe0d045af6d20828d62840 Gerrit-Change-Number: 23524 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 24 Oct 2025 04:58:09 +0000 Gerrit-HasComments: Yes
