Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23604 )
Change subject: IMPALA-13263: Add overload for ST_ConvexHull() and corresponding tests ...................................................................... Patch Set 1: (4 comments) > Patch Set 1: > > Build Successful > > https://jenkins.impala.io/job/gerrit-code-review-checks/20781/ : Initial code > review checks passed. Use gerrit-verify-dryrun-external or > gerrit-verify-dryrun to run full precommit tests. Thanks Arnab! Added some comments. Please run the jenkins job as well. http://gerrit.cloudera.org:8080/#/c/23604/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23604/1//COMMIT_MSG@9 PS1, Line 9: to support additional : input types. Can you explain that here with an example? http://gerrit.cloudera.org:8080/#/c/23604/1//COMMIT_MSG@11 PS1, Line 11: geometry nit: geometric http://gerrit.cloudera.org:8080/#/c/23604/1//COMMIT_MSG@12 PS1, Line 12: : New tests wer Adding a Testing header and mention the name and nature of the tests. http://gerrit.cloudera.org:8080/#/c/23604/1/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test File testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test: http://gerrit.cloudera.org:8080/#/c/23604/1/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test@2720 PS1, Line 2720: t ST_AsText(ST_ConvexHul Can we add some negative tests to see if all cases are handled? Also add a comment explaining why these tests are added. -- To view, visit http://gerrit.cloudera.org:8080/23604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb17d98f5e75929ec0143aa16195a84dd6e50796 Gerrit-Change-Number: 23604 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Tue, 28 Oct 2025 09:00:57 +0000 Gerrit-HasComments: Yes
