Pranav Lodha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23592 )

Change subject: IMPALA-13788: [DOCS] Docs for query options 
SYNC_HMS_EVENTS_WAIT_TIME_S  and SYNC_HMS_EVENTS_STRICT_MODE
......................................................................


Patch Set 2:

(6 comments)

Thanks Sanjana! Please add one or two sentences on operational guidance eg. 
when to enable.

http://gerrit.cloudera.org:8080/#/c/23592/2/docs/topics/impala_sync_hms_events_strict_mode.xml
File docs/topics/impala_sync_hms_events_strict_mode.xml:

http://gerrit.cloudera.org:8080/#/c/23592/2/docs/topics/impala_sync_hms_events_strict_mode.xml@35
PS2, Line 35: SYNC_HMS_EVENTS_STRICT_MODE
Can we add some usecases for when this is recommended?


http://gerrit.cloudera.org:8080/#/c/23592/2/docs/topics/impala_sync_hms_events_strict_mode.xml@36
PS2, Line 36:  cannot successfully sync
Does failing the query produce error? Might be good to show an example output 
or typical error string.


http://gerrit.cloudera.org:8080/#/c/23592/2/docs/topics/impala_sync_hms_events_strict_mode.xml@43
PS2, Line 43: false
nit: False


http://gerrit.cloudera.org:8080/#/c/23592/2/docs/topics/impala_sync_hms_events_strict_mode.xml@50
PS2, Line 50: false</codeph>(Non-Strict Mode - Default)
Make it False (Non-Strict Mode ....)


http://gerrit.cloudera.org:8080/#/c/23592/2/docs/topics/impala_sync_hms_events_strict_mode.xml@51
PS2, Line 51: startsplanning
nit: starts planning


http://gerrit.cloudera.org:8080/#/c/23592/2/docs/topics/impala_sync_hms_events_wait_time_s.xml
File docs/topics/impala_sync_hms_events_wait_time_s.xml:

http://gerrit.cloudera.org:8080/#/c/23592/2/docs/topics/impala_sync_hms_events_wait_time_s.xml@40
PS2, Line 40: > =
remove space



--
To view, visit http://gerrit.cloudera.org:8080/23592
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia11663c5e84794d4bca658124cde59bf97aa7158
Gerrit-Change-Number: 23592
Gerrit-PatchSet: 2
Gerrit-Owner: Sanjana Malhotra <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 30 Oct 2025 04:43:04 +0000
Gerrit-HasComments: Yes

Reply via email to