Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23610 )

Change subject: IMPALA-14515: Update mysql-connector-j to always get the latest 
version
......................................................................


Patch Set 2:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh
File testdata/bin/setup-mysql-env.sh:

http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh@243
PS2, Line 243: LATEST=$(curl -s 
https://repo1.maven.org/maven2/com/mysql/mysql-connector-j/maven-metadata.xml | 
grep -oPm1 "(?<=<release>)[^<]+")
line too long (130 > 90)


http://gerrit.cloudera.org:8080/#/c/23610/2/testdata/bin/setup-mysql-env.sh@244
PS2, Line 244: wget 
"https://repo1.maven.org/maven2/com/mysql/mysql-connector-j/${LATEST}/mysql-connector-j-${LATEST}.tar.gz";
line too long (110 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4881d31d46c381abc9cdbb0694bbbbeaa9ede2
Gerrit-Change-Number: 23610
Gerrit-PatchSet: 2
Gerrit-Owner: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Thu, 30 Oct 2025 04:58:21 +0000
Gerrit-HasComments: Yes

Reply via email to