Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20386 )
Change subject: IMPALA-12389: Use -skipTrash for HadoopFsCommandLineClient::delete_file_dir ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/20386/10/tests/conftest.py File tests/conftest.py: http://gerrit.cloudera.org:8080/#/c/20386/10/tests/conftest.py@410 PS10, Line 410: if request.instance.filesystem_client.exists(db_location): I'd prefer to see this as an optimization on DelegatingHdfsClient.delete_file_dir. If we're working with an filesystem using HadoopFsCommandLineClient, then it doubles the number of command-line runs. If implemented in DelegatingHdfsClient.delete_file_dir, you can be sure we use the webhdfs client for exists. -- To view, visit http://gerrit.cloudera.org:8080/20386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d304113596aaf70a122202a33276fc7c3d599e8 Gerrit-Change-Number: 20386 Gerrit-PatchSet: 10 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 31 Oct 2025 18:57:40 +0000 Gerrit-HasComments: Yes
