Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23594 )

Change subject: IMPALA-14527: Set mold as the default linker
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23594/6/buildall.sh
File buildall.sh:

http://gerrit.cloudera.org:8080/#/c/23594/6/buildall.sh@84
PS6, Line 84: # Limit mold to a single job to avoid excessive memory 
consumption while fully utilizing
            : # available CPUs.
            : export MOLD_JOBS=1
> I think buildall.sh is not quite the right place for this. If we want it to
I figured it was primarily useful when doing a full build, with multiple link 
operations. But moving it to impala-config.sh isn't a big deal, most dev 
workflows are going to do 1 or 2 links, and they shouldn't be any slower with 
this option.



--
To view, visit http://gerrit.cloudera.org:8080/23594
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0112f23feb1bfdf36977fafc16f366c54fea5546
Gerrit-Change-Number: 23594
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 04 Nov 2025 21:19:23 +0000
Gerrit-HasComments: Yes

Reply via email to