Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23524 )
Change subject: WIP: do not review, Calcite patch with most fixes for v1 ...................................................................... Patch Set 14: (18 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedInPredicate.java@40 PS14, Line 40: protected static final Logger LOG = LoggerFactory.getLogger(AnalyzedInPredicate.class.getName()); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java@46 PS14, Line 46: * Impala provides, not the default type. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java@50 PS14, Line 50: public ImpalaRexSimplify(RexBuilder rexBuilder, RexExecutor executor) { line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@228 PS14, Line 228: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java@162 PS14, Line 162: RexNode expandedOperand = ImpalaRexUtil.expandSearch(visitor.getRexBuilder(), operand); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java@52 PS14, Line 52: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java@68 PS14, Line 68: Filter newFilter = filter.copy(filter.getTraitSet(), filter.getInput(0), newCondition); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaIntersectToDistinctRule.java@44 PS14, Line 44: * line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinSimplifyRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinSimplifyRule.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaJoinSimplifyRule.java@51 PS14, Line 51: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaProjectSimplifyRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaProjectSimplifyRule.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaProjectSimplifyRule.java@39 PS14, Line 39: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaProjectSimplifyRule.class.getName()); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaProjectSimplifyRule.java@54 PS14, Line 54: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaSortRemoveConstantKeysRule.java@92 PS14, Line 92: return false; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RuleEventLogger.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RuleEventLogger.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RuleEventLogger.java@37 PS14, Line 37: private static final Logger LOG = LoggerFactory.getLogger(RuleEventLogger.class.getName()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RuleEventLogger.java@58 PS14, Line 58: String ruleArgs = Arrays.stream(call.rels).map(rel -> "rel#" + rel.getId() + ":" + rel.getRelTypeName()) line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RuleEventLogger.java@82 PS14, Line 82: String description = newRel == null ? "null" : "rel#" + newRel.getId() + ":" + newRel.getRelTypeName(); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/RuleEventLogger.java@84 PS14, Line 84: LOG.info("call#{}: Rule [{}] produced [{}]", call.id, call.getRule(), description); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@194 PS14, Line 194: RelOptCluster newCluster = RelOptCluster.create(planner_, rexBuilder); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java File java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java: http://gerrit.cloudera.org:8080/#/c/23524/14/java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java@83 PS14, Line 83: protected static final Logger LOG = LoggerFactory.getLogger(TestReduceExprShuttle.class.getName()); line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc0d0101a8136d8ef7fe0d045af6d20828d62840 Gerrit-Change-Number: 23524 Gerrit-PatchSet: 14 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 05 Nov 2025 00:31:40 +0000 Gerrit-HasComments: Yes
