Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23642 )

Change subject: PROTOTYPE: Use Clang 12 for sanitizer builds
......................................................................


Patch Set 1:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23642/1/be/src/util/lru-multi-cache.inline.h
File be/src/util/lru-multi-cache.inline.h:

http://gerrit.cloudera.org:8080/#/c/23642/1/be/src/util/lru-multi-cache.inline.h@52
PS1, Line 52: auto LruMultiCache<KeyType, 
ValueType>::Accessor::operator=(Accessor&& rhs) noexcept -> Accessor& {
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/23642/1/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/23642/1/bin/impala-config.sh@1142
PS1, Line 1142: export 
ASAN_SYMBOLIZER_PATH="${IMPALA_TOOLCHAIN_PACKAGES_HOME}/llvm-${IMPALA_CLANG_VERSION}/bin/llvm-symbolizer"
line too long (112 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23642
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41a9ecaf56edb576fbba8f0c64940e0412538062
Gerrit-Change-Number: 23642
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 05 Nov 2025 23:43:40 +0000
Gerrit-HasComments: Yes

Reply via email to