Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23646 )
Change subject: IMPALA-14533: Fix crash in ASAN/TSAN builds due to nullptr TcmallocMetric::BYTES_IN_USE ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23646/2/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/23646/2/be/src/scheduling/admission-controller.cc@1656 PS2, Line 1656: DCHECK(SanitizerMallocMetric::BYTES_ALLOCATED != nullptr); Can you add a comment linking this to memory-metrics.cc#RegisterMemoryMetrics? -- To view, visit http://gerrit.cloudera.org:8080/23646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4fbdc134ea302f7302d177d073eb49136ba775c Gerrit-Change-Number: 23646 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 06 Nov 2025 05:11:39 +0000 Gerrit-HasComments: Yes
