Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23646 )
Change subject: IMPALA-14533: Fix crash in ASAN/TSAN builds due to nullptr TcmallocMetric::BYTES_IN_USE ...................................................................... IMPALA-14533: Fix crash in ASAN/TSAN builds due to nullptr TcmallocMetric::BYTES_IN_USE Impala uses SanitizerMallocMetric::BYTES_ALLOCATED instead of TcmallocMetric::BYTES_IN_USE in ASAN or TSAN builds. However, the admissiond logic in IMPALA-14493 still uses uninitialized TcmallocMetric::BYTES_IN_USE under these builds, leading to a nullptr crash. To fix this issue, we will use SanitizerMallocMetric::BYTES_ALLOCATED instead for ASAN and TSAN builds in admission controller, which is the same logic in memory-metrics.cc to use a different metric for those builds. Tests: Passed ASAN and TSAN builds testing. Passed core tests. Change-Id: Ic4fbdc134ea302f7302d177d073eb49136ba775c Reviewed-on: http://gerrit.cloudera.org:8080/23646 Reviewed-by: Michael Smith <[email protected]> Tested-by: Michael Smith <[email protected]> --- M be/src/scheduling/admission-controller.cc 1 file changed, 23 insertions(+), 13 deletions(-) Approvals: Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic4fbdc134ea302f7302d177d073eb49136ba775c Gerrit-Change-Number: 23646 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
