Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23562 )
Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/23562/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/23562/2/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@a506 PS2, Line 506: : : : > Done I don't quite get the logic of why createDataSink makes sense, but it looks like it's trying to be closer to SelectStmt.analyze but still able to route it to a PlanRootSink so we can make it part of query options. Overall the changes look reasonable though. http://gerrit.cloudera.org:8080/#/c/23562/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/23562/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@130 PS5, Line 130: while (relNode instanceof Filter || relNode instanceof Project) { Is there a more generalized version of this? Seems like it might be something we need to do somewhat regularly. http://gerrit.cloudera.org:8080/#/c/23562/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java: http://gerrit.cloudera.org:8080/#/c/23562/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java@253 PS5, Line 253: // This is a deprecated class, so the spool option is not supported here and set Is there somewhere else talking about why it's deprecated? http://gerrit.cloudera.org:8080/#/c/23562/5/testdata/workloads/functional-query/queries/QueryTest/calcite.test File testdata/workloads/functional-query/queries/QueryTest/calcite.test: http://gerrit.cloudera.org:8080/#/c/23562/5/testdata/workloads/functional-query/queries/QueryTest/calcite.test@1127 PS5, Line 1127: row_regex: .*SPOOL_QUERY_RESULTS=0.* Should there be a SPOOL_QUERY_RESULTS=1 case? -- To view, visit http://gerrit.cloudera.org:8080/23562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f Gerrit-Change-Number: 23562 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 06 Nov 2025 22:00:31 +0000 Gerrit-HasComments: Yes
