Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22090 )

Change subject: IMPALA-13563: Cleanup logging
......................................................................


Patch Set 7: Code-Review+2

(1 comment)

Carry +2.

http://gerrit.cloudera.org:8080/#/c/22090/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java:

http://gerrit.cloudera.org:8080/#/c/22090/6/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteMetadataHandler.java@358
PS6, Line 358: he_.tables.values().stream()
             :         .map(feTable -> feTable.getName().toString())
             :         .collect(Collectors.joining( ", " ))
> nit: Might be more readable if stored to variable first.
Done



--
To view, visit http://gerrit.cloudera.org:8080/22090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32e1c62511c292d36aa879c60ae3d91ed4f65697
Gerrit-Change-Number: 22090
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Tue, 11 Nov 2025 00:47:12 +0000
Gerrit-HasComments: Yes

Reply via email to