Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23536 )

Change subject: IMPALA-13066: Extend SHOW CREATE TABLE to include stats and 
partitions
......................................................................


Patch Set 12: Code-Review+2

(1 comment)

LGTM. Carrying Riza's +1. Thanks for your contribution, Arnab!

http://gerrit.cloudera.org:8080/#/c/23536/10/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java
File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java:

http://gerrit.cloudera.org:8080/#/c/23536/10/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@658
PS10, Line 658:       out.append("ALTER TABLE ")
              :           
.append(getIdentSql(table.getDb().getName())).append('.')
              :           .append(getIdentSql(table.getName())).append(' ')
              :           .append("SET TBLPROPERTIES ")
              :           .append(propertyMapToSql(allTblProps))
              :           .append(";\n\n");
              :     }
              :
              :     // Column stats for non-partition columns
              :     if (appendColumnStatsStatements(table, out)) {
              :       out.append("\n");
              :     }
              :
              :     /
> Apologies, yes you were right, these references do point out htat both tabl
Ack



--
To view, visit http://gerrit.cloudera.org:8080/23536
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87950ae9d9bb73cb2a435cf5bcad076df1570dc2
Gerrit-Change-Number: 23536
Gerrit-PatchSet: 12
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 11 Nov 2025 01:00:58 +0000
Gerrit-HasComments: Yes

Reply via email to