ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/21724 )
Change subject: IMPALA-14183: Rename the environment variable USE_APACHE_HIVE to USE_APACHE_HIVE_3 ...................................................................... Patch Set 30: (3 comments) Hi, Pranav Lodha! Thanks for your review! http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh@426 PS29, Line 426: > If someone uses USE_APACHE_HIVE=true, do we wanna have a fallback with a wa Hi! I think it would be better to specify the major version of hive in the environment variables. http://gerrit.cloudera.org:8080/#/c/21724/29/bin/impala-config.sh@446 PS29, Line 446: hive-3 > nit: Shouldn't this be hive-3.x? At the build time, based on the environment variable IMPALA_HIVE_DIST_TYPE one of the two shims is added to as source using the fe/pom.xml build plugin. It is clearer to retain only the information of the major version. http://gerrit.cloudera.org:8080/#/c/21724/29/common/function-registry/CMakeLists.txt File common/function-registry/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/21724/29/common/function-registry/CMakeLists.txt@64 PS29, Line 64: $ > nit: remove space Done -- To view, visit http://gerrit.cloudera.org:8080/21724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11b5fe1604b6fc34469fb357c98784b7ad88574d Gerrit-Change-Number: 21724 Gerrit-PatchSet: 30 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 13:03:17 +0000 Gerrit-HasComments: Yes
