Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23154 )
Change subject: IMPALA-9846: Enable Aggregated Runtime Profile by Default ...................................................................... Patch Set 13: > I just realized that non-aggregated profiles were also changed by adding > "total" to averaged fragments. Yes, I agree traditional profile should not be changed at all for this non-critical reason. In the process of fixing tests for successful builds, I had forgotten that I intended to fix this. I have eliminated 'mean' value from traditional profiles and replaced it with 'total' in the process, this is not at all agreeable. This was done for the 119 row_regex tests, which try to match raw counter values with text profile. As the raw counter values do not exist in aggregated profile and total differs from raw counter values, 'total=' was used as substitute. This seems like a great opportunity to replace these 119 row_regex tests with aggregation() or regex "or" operator where needed. Thank you for reminding me of this mistake. I will make sure to remove lines https://gerrit.cloudera.org/#/c/23154/21/be/src/util/runtime-profile.cc@2322 and return the profile to its original form. -- To view, visit http://gerrit.cloudera.org:8080/23154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If41d6322361fba82c946efd614cc7d28cb1c36e8 Gerrit-Change-Number: 23154 Gerrit-PatchSet: 13 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 17:47:10 +0000 Gerrit-HasComments: No
