Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10707 )
Change subject: IMPALA-4908: NULL floats don't compare equal to other NULL floats ...................................................................... IMPALA-4908: NULL floats don't compare equal to other NULL floats This change ensures that comparing two NULL floats with different val fields returns true. Although this is undefined behavior, it is now consistent with other types. Along with the change, a unit test was added to ensure that equality checking of floats returns results as expected. Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975 Reviewed-on: http://gerrit.cloudera.org:8080/10707 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/udf/udf-test.cc M be/src/udf/udf.h 2 files changed, 28 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie7310645e5752d8203be5abc22a6562a59b6e975 Gerrit-Change-Number: 10707 Gerrit-PatchSet: 3 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>