Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10715 )
Change subject: IMPALA-5216: Make admission control queuing async ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/10715/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/10715/1/be/src/scheduling/admission-controller.cc@535 PS1, Line 535: PrintId Some PrintId() were missing. This was a compile error on 2.x because of the different thrift version. http://gerrit.cloudera.org:8080/#/c/10715/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/10715/1/be/src/service/client-request-state.cc@496 PS1, Line 496: if (exec_env_->admission_controller() != nullptr) { There was a conflict here - this is a DCHECK on master because we don't support running with AC disabled. http://gerrit.cloudera.org:8080/#/c/10715/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/10715/1/tests/query_test/test_observability.py@92 PS1, Line 92: handle = self.execute_query_async(query, There was a conflict here because of using a different query option. I just switched to the master version of the test, since it works on both branches. -- To view, visit http://gerrit.cloudera.org:8080/10715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: 2.x Gerrit-MessageType: comment Gerrit-Change-Id: I989cf5b259afb8f5bc5c35590c94961c81ce88bf Gerrit-Change-Number: 10715 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 00:48:02 +0000 Gerrit-HasComments: Yes
