Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23670 )

Change subject: IMPALA-12893: (part 2): Upgrade Iceberg to version 1.5.2
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

LGTM. Thank you for taking care of this!

http://gerrit.cloudera.org:8080/#/c/23670/1/testdata/workloads/functional-query/queries/QueryTest/show-create-table-with-stats.test
File 
testdata/workloads/functional-query/queries/QueryTest/show-create-table-with-stats.test:

http://gerrit.cloudera.org:8080/#/c/23670/1/testdata/workloads/functional-query/queries/QueryTest/show-create-table-with-stats.test@68
PS1, Line 68: 
'write.merge.mode'='merge-on-read'='write.parquet.compression-codec'='snappy'='write.update.mode'='merge-on-read');
This looks wrong. Should it be like this?

  'write.merge.mode'='merge-on-read', 
'write.parquet.compression-codec'='snappy', 
'write.update.mode'='merge-on-read');



--
To view, visit http://gerrit.cloudera.org:8080/23670
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4f9ed3f7ee9f686044023be938d6b1d18c8842e
Gerrit-Change-Number: 23670
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 13 Nov 2025 15:30:12 +0000
Gerrit-HasComments: Yes

Reply via email to