Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23566 )
Change subject: IMPALA-14065: Support WHERE clause in SHOW PARTITIONS statement ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/23566/5/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23566/5/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@39 PS5, Line 39: import org.apache.impala.analysis.AnalyticExpr; : import org.apache.impala.analysis.CompoundVerticalBarExpr; : import org.apache.impala.analysis.SlotId; : import org.apache.impala.analysis.Subquery; nit: don't need these imports since they are in the same package http://gerrit.cloudera.org:8080/#/c/23566/5/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@65 PS5, Line 65: op_ = Preconditions.checkNotNull(op); : tableName_ = Preconditions.checkNotNull(tableName); : whereClause_ = null; nit: replace with "this(tableName, op, null);" to reduce duplicate codes. http://gerrit.cloudera.org:8080/#/c/23566/5/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/23566/5/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@a507 PS5, Line 507: : : nit: Let's not remove comments like this during refactoring. http://gerrit.cloudera.org:8080/#/c/23566/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/23566/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4481 PS5, Line 4481: // WHERE clause with Kudu table should fail (non-HDFS tables don't support WHERE) How about Iceberg tables? Do we support them as well? We have some iceberg tables like functional_parquet.iceberg_partitioned. Please also add one in the test. -- To view, visit http://gerrit.cloudera.org:8080/23566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2a14aabcea3fb17083d4ad6f87b7861113f89e Gerrit-Change-Number: 23566 Gerrit-PatchSet: 5 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 14:17:31 +0000 Gerrit-HasComments: Yes
