Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23627 )
Change subject: IMPALA-14553: Run schema eval concurrently ...................................................................... Patch Set 13: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23627/13/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/23627/13/testdata/bin/generate-schema-statements.py@821 PS13, Line 821: for section in new_sections: nit: Can call pool.close() and pool.join() before this loop? http://gerrit.cloudera.org:8080/#/c/23627/13/testdata/bin/generate-schema-statements.py@852 PS13, Line 852: sections = eval_sections(test_vectors, sections, : schema_only, schema_include, schema_exclude) nit: It will be great if we can measure and log how long this step is taking time. -- To view, visit http://gerrit.cloudera.org:8080/23627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a78d05fd6a0005c83561978713237da2dde6af2 Gerrit-Change-Number: 23627 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 17:40:27 +0000 Gerrit-HasComments: Yes
