Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10702 )
Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh@230 PS2, Line 230: # bin/impala-config-local.sh to set JAVA_HOME, so it is important to pick up that We could remove this from bootstrap_development as part of this change. http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh@238 PS2, Line 238: SYSTEM_JAVA_HOME=$(readlink -f /usr/bin/javac | sed "s:bin/javac::") > How about using "which javac" and "JAVA_HOME=$(which javac|xargs readlink - I think Tianyi is right here in that we should honor the javac that's on the PATH if we're picking a default. http://gerrit.cloudera.org:8080/#/c/10702/2/bin/impala-config.sh@241 PS2, Line 241: # Prefer the JAVA_HOME set in the environment, but use the system's JAVA_HOME otherwise If you don't mind, could you remove the following line in this change. $git grep JAVA_HOME | grep entrypoi docker/entrypoint.sh: export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 -- To view, visit http://gerrit.cloudera.org:8080/10702 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf3521b4f44fdbdc841a90fd00c477c9423a75bb Gerrit-Change-Number: 10702 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 03:28:26 +0000 Gerrit-HasComments: Yes
