Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23562 )
Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/23562/13/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaPlanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaPlanRel.java: http://gerrit.cloudera.org:8080/#/c/23562/13/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaPlanRel.java@117 PS13, Line 117: return canPassThroughParentAggregate((RelNode) planRel); > This is only called by ParentPlanRelContext.Builder(). I'm guessing this is Looks like you both may be right. I did only create it as a helper method. I made the ImpalaPlanRel interface because I was adding new methods that only my RelNodes needed. I only thought to create a new interface because I figured classes like ImpalaAggRel already implemented RelNode, so now I need a new interface. But having ImpalaPlanRel derive from RelNode actually solves the problem. It compiles for me and should work fine. So we can add the change Michael suggests, and I think that makes the code better. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/23562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f Gerrit-Change-Number: 23562 Gerrit-PatchSet: 13 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 23:28:59 +0000 Gerrit-HasComments: Yes
