Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23604 )
Change subject: IMPALA-13263: Add single-argument overload for ST_ConvexHull() ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/23604/6/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test File testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test: http://gerrit.cloudera.org:8080/#/c/23604/6/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test@2721 PS6, Line 2721: # PostGIS would return: POINT (1 2) Created ticket for this in Hive, can you mention HIVE-29323? http://gerrit.cloudera.org:8080/#/c/23604/6/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test@2761 PS6, Line 2761: select ST_AsText(ST_ConvexHull(ST_GeomFromText('point empty'))); This query is duplicated. Note that Impala's test framework checks RESULTS for the last query, so this is why the test passes. http://gerrit.cloudera.org:8080/#/c/23604/6/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test@2795 PS6, Line 2795: select ST_AsText(ST_ConvexHull(ST_Point(0, 0), ST_Point(5, 0), ST_Point(5, 5), ST_Point(0, 5), ST_LineString(1, 1, 4, 4), ST_Point(6, 3))); duplicate test -- To view, visit http://gerrit.cloudera.org:8080/23604 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb17d98f5e75929ec0143aa16195a84dd6e50796 Gerrit-Change-Number: 23604 Gerrit-PatchSet: 6 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Mon, 17 Nov 2025 19:30:56 +0000 Gerrit-HasComments: Yes
