Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23665 )
Change subject: IMPALA-14405 ADDENDUM: Catch exception for bad column names ...................................................................... Patch Set 1: Code-Review+2 (1 comment) The exception handling itself make sense to me. I just have nit/question. http://gerrit.cloudera.org:8080/#/c/23665/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23665/1//COMMIT_MSG@24 PS1, Line 24: "select timestamp_col + interval 3 nanoseconds" nit: I suggest to put runable SQL as example test case. select timestamp_col + interval 3 nanoseconds from functional.alltypestiny; Btw, I manually try this test case without the patch and it seems doing OK. Why is that? start-impala-cluster.py --env_vars=USE_CALCITE_PLANNER=true \ && impala-shell.sh \ -q "select timestamp_col + interval 3 nanoseconds from functional.alltypestiny;" +----------------------------------------+ | timestamp_col + interval 3 nanoseconds | +----------------------------------------+ | 2009-03-01 00:00:00.000000003 | | 2009-03-01 00:01:00.000000003 | | 2009-02-01 00:00:00.000000003 | | 2009-02-01 00:01:00.000000003 | | 2009-01-01 00:00:00.000000003 | | 2009-01-01 00:01:00.000000003 | | 2009-04-01 00:00:00.000000003 | | 2009-04-01 00:01:00.000000003 | +----------------------------------------+ This is also fine: select cast("2009-03-01 00:00:00.000000003" as TIMESTAMP) + interval 3 nanoseconds; +-----------------------------------------------------------------------------+ | cast('2009-03-01 00:00:00.000000003' as timestamp) + interval 3 nanoseconds | +-----------------------------------------------------------------------------+ | 2009-03-01 00:00:00.000000006 | +-----------------------------------------------------------------------------+ -- To view, visit http://gerrit.cloudera.org:8080/23665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c4d76a25fb2486eb1ef19485bce7888d45d282f Gerrit-Change-Number: 23665 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 17 Nov 2025 22:16:35 +0000 Gerrit-HasComments: Yes
