Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 )
Change subject: IMPALA-3307: Add support for IANA time-zone db ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/9986/17/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: http://gerrit.cloudera.org:8080/#/c/9986/17/be/src/exprs/timezone_db.cc@367 PS17, Line 367: while (true) { : current_bytes_read = hdfsRead(hdfs_co > nit: this could fit in one line Done http://gerrit.cloudera.org:8080/#/c/9986/18/be/src/util/zip-util.h File be/src/util/zip-util.h: http://gerrit.cloudera.org:8080/#/c/9986/18/be/src/util/zip-util.h@33 PS18, Line 33: > nit: comment formatting - should start with /// Done http://gerrit.cloudera.org:8080/#/c/9986/10/testdata/tzdb/2017c/Africa/Abidjan File testdata/tzdb/2017c/Africa/Abidjan: http://gerrit.cloudera.org:8080/#/c/9986/10/testdata/tzdb/2017c/Africa/Abidjan@1 PS10, Line 1: ../Atlantic/St_Helena > How does they pass the rat checks? We run those precommit. I expected to se I've updated rat_exclude_files.txt in patch-set #11 and #13. I ran the rat checks with that and they passed. -- To view, visit http://gerrit.cloudera.org:8080/9986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I93c1fbffe81f067919706e30db0a34d0e58e7e77 Gerrit-Change-Number: 9986 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 15:27:02 +0000 Gerrit-HasComments: Yes
