Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23600 )
Change subject: [PROTOTYPE] IMPALA-14512: Remove dependency on sh python package ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23600/6/bin/single_node_perf_run.py File bin/single_node_perf_run.py: http://gerrit.cloudera.org:8080/#/c/23600/6/bin/single_node_perf_run.py@103 PS6, Line 103: return subprocess.check_output(["git"] + args, text=True) > For some of them, I want to capture stdout and return the string. Others, I Oh, overlooked check_output vs check_call. -- To view, visit http://gerrit.cloudera.org:8080/23600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5f9316a5d83c5c0dc37d4a94c55b6a655765fe3 Gerrit-Change-Number: 23600 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 18 Nov 2025 18:34:39 +0000 Gerrit-HasComments: Yes
